Skip to content

Document System.IO.StringReader #3619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2019
Merged

Document System.IO.StringReader #3619

merged 2 commits into from
Dec 4, 2019

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases labels Dec 3, 2019
@carlossanlop carlossanlop added this to the December 2019 milestone Dec 3, 2019
@carlossanlop carlossanlop requested review from JeremyKuhne, jozkee and a team December 3, 2019 21:55
@carlossanlop carlossanlop self-assigned this Dec 3, 2019
@gewarren gewarren requested review from gewarren and removed request for a team December 3, 2019 22:59
gewarren
gewarren requested changes Dec 3, 2019
View reviewed changes
@carlossanlop @gewarren
suggestions by gewarren
0efb6aa 
Co-Authored-By: Genevieve Warren <[email protected]>
@carlossanlop carlossanlop added changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Dec 3, 2019
@carlossanlop
Copy link
Contributor Author

Thanks for your review, @gewarren. I applied all your suggestions. If all looks good, feel free to sign off whenever you get a chance.

gewarren
gewarren approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, please just check that there are no build warnings for the xrefs.

@carlossanlop carlossanlop merged commit 973479a into dotnet:master Dec 4, 2019
@carlossanlop carlossanlop deleted the StringReader branch December 4, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@JeremyKuhne JeremyKuhne Awaiting requested review from JeremyKuhne

@jozkee jozkee Awaiting requested review from jozkee

Assignees

@carlossanlop carlossanlop

Labels
changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review 🏁 Release: .NET Core 2.x Identifies work items for the .NET Core 2.x releases new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
December 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@carlossanlop @gewarren @mairaw